feat(attributes): Add several measurement attributes#362
Merged
Conversation
loewenheim
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛Attributes
Other
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7a0b3e4. Configure here.
Lms24
approved these changes
May 18, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM once the stall_total_time type discussion is resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the attributes
frames_frozen_rateframes_slow_ratestall_total_timestall_percentageThese attributes are the equivalents of measurements accessed/computed by Relay in https://github.com/getsentry/relay/blob/2061055ea0e7a82266ba4c90205c416daa04875d/relay-event-normalization/src/event.rs#L1094-L1145. Defining them as attributes is a prerequisite to running the same computation for V2 spans.
This PR intentionally doesn't put the attributes under their "proper" names (I don't know in all cases what those would be, but I know that they wouldn't be this). This is because Relay converts measurements to attributes 1-to-1, so to preserve parity between V1 and V2 spans, we want to reuse the names. Renaming the attributes can later be accomplished through the normal deprecation process.
ref: INGEST-909
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)